CORE-1972 don't mark rebalance complete if some partitions are not moveable #18489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-repeat |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49129#018f7951-56a3-47b4-bc58-0b5961ed1ceb ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49153#018f7c66-6a5e-452d-a79c-1540a1dac8a2 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49153#018f7c86-2962-4633-9f03-acf23639d7ab |
Previously, we finished counts rebalance if no new moves could be found, even when some partitions were not moveable. This could lead to finishing too early and not achieving balanced distribution when many partitions were not moveable (e.g. because they are disabled due to recovery mode).
Allows not starting all nodes at once.
Test that rebalancing after node addition eventually achieves balanced distribution, even though some nodes were temporarily in recovery mode.
ztlpn
force-pushed
the
fix-balancer-mark-rebalance-complete
branch
from
83f0d44 to
588ca47
Compare
ztlpn
changed the title
dotnwat
reviewed
May 15, 2024
Comment on lines
1277
to
+1279
| _ntp, | ||
| move.current(), | ||
| move.previous()); | ||
| move.previous(), | ||
| move.current()); |
There was a problem hiding this comment.
It's an assert so I guess nobody noticed 🤷♂️ no idea why I wrote it like this in the first place
bharathv
approved these changes
May 16, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we finished counts rebalance if no new moves could be found, even when some partitions were not moveable. This could lead to finishing too early and not achieving balanced distribution when many partitions were not moveable (e.g. because they are disabled due to recovery mode).
Backports Required
Release Notes
Bug Fixes