Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvlog: miscellaneous non-functional changes #18519

Merged
merged 3 commits into from
May 16, 2024
Merged

mvlog: miscellaneous non-functional changes #18519

merged 3 commits into from
May 16, 2024

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented May 16, 2024

This PR includes a few small non-functional changes related to the mvlog.

  • adds a size() call to the interval_set (not quite in mvlog subsystem, but it is the only user at the moment)
  • migrates mvlog to use mvlog::file instead of io::pager and friends directly
  • expands some test coverage

There are no functional changes in this PR.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@andrwng andrwng mentioned this pull request May 16, 2024
Merged
7 tasks
@andrwng
Copy link
Contributor Author

andrwng commented May 16, 2024

/ci-repeat

@andrwng andrwng requested review from dotnwat, jcipar and WillemKauf May 16, 2024 15:14
@andrwng
container: add interval_set::size()
b2cb2fd 
This is useful for testing.
@andrwng andrwng force-pushed the mvlog-non-functionals branch from 361657f to bfeaeb6 Compare May 16, 2024 16:45
andrwng added 2 commits May 16, 2024 10:33
@andrwng
mvlog: use file abstraction instead of pager
1a374dd
@andrwng
mvlog/tests: additional coverage for skipping streams
5cc0fe6 
Adjusts some tests that exercise reading near or past the end. I found
myself writing these in order to locate a bug that ended up not being in
the skipping_data_source.
@andrwng andrwng force-pushed the mvlog-non-functionals branch from bfeaeb6 to 5cc0fe6 Compare May 16, 2024 17:34
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/49238#018f82d0-fee9-4354-9425-fed61e531896:

"rptest.tests.write_caching_fi_e2e_test.WriteCachingFailureInjectionE2ETest.test_crash_all_with_consumer_group"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 16, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49238#018f82d0-feee-484c-8c97-be42e22102b8

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49238#018f82d0-fee9-4354-9425-fed61e531896

@andrwng
Copy link
Contributor Author

andrwng commented May 16, 2024

CI failures are unrelated: this PR has no functional changes to prod code

@andrwng andrwng merged commit d79e842 into redpanda-data:dev May 16, 2024
18 checks passed
dotnwat
dotnwat reviewed May 21, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat left review comments

@WillemKauf WillemKauf WillemKauf approved these changes

@jcipar jcipar Awaiting requested review from jcipar

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrwng @vbotbuildovich @dotnwat @WillemKauf