Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/crypto: Fixed issue with RP not going into FIPS mode #18629

Merged

Conversation

michael-redpanda
Copy link
Contributor

Was not using the correct instance of node_config when determining whether to put the OpenSSL context service into FIPS mode or not.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • None

@michael-redpanda michael-redpanda self-assigned this May 22, 2024
@michael-redpanda michael-redpanda requested review from a team and aanthony-rp and removed request for a team May 22, 2024 16:33
@michael-redpanda michael-redpanda requested a review from oleiman May 22, 2024 16:33
oleiman
oleiman previously approved these changes May 22, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

src/v/crypto/ossl_context_service.cc Outdated Show resolved Hide resolved
src/v/redpanda/application.cc Show resolved Hide resolved
Was not using the correct instance of node_config when determining
whether to put the OpenSSL context service into FIPS mode or not.

Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda
Copy link
Contributor Author

Force push 79062a6:

  • Using vlog

@michael-redpanda michael-redpanda requested a review from oleiman May 23, 2024 11:55
@michael-redpanda
Copy link
Contributor Author

/cdt
fips

Copy link
Contributor

@aanthony-rp aanthony-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. don't know much about vlog but it looks like a cleaner interface than what we had.

@michael-redpanda
Copy link
Contributor Author

I'm going to let CDT FIPS run to see if that produces anything 'funny' that would have to be addressed.

@michael-redpanda michael-redpanda merged commit 7d23744 into redpanda-data:dev May 24, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants