rpk: allow seeking a non-existent group #18667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to set commits for a group that does not yet exist. This was not previously possible because the first thing rpk did when seeking was to query old offsets. If old offsets did not exist, rpk would exit with an error that offsets were unable to be fetched.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49564#018fb365-2807-4bd4-b938-b3b9b3d7ecbf |
r-vasquez
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to set commits for a group that does not yet exist. This was not previously possible because the first thing rpk did when seeking was to query old offsets. If old offsets did not exist, rpk would exit with an error that offsets were unable to be fetched.
Backports Required
Release Notes
Improvements
rpk group seekto set commits on a group that does not yet exist