More typing 4 #18686
Merged
More typing 4 #18686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the rcast function which does a runtime cast.
Fix the 11 type checking errors in rptest/archival, so the entire directory is clean at standard level.
Fix the 3 type checking errors in rptest/compatibility, so the entire directory is clean at standard level.
Fix the 2 type checking errors in services/provider_clients, so the entire directory is clean at standard level.
Miscellaneous typing fixes with the goal of getting specific files which have only a few errors to zero.
Typing enhancements for OMB service and associated classes.
StephanDollberg
approved these changes
May 29, 2024
|
|
||
| def validate(self, ctx) -> bool: | ||
| pass |
There was a problem hiding this comment.
Is pass not cool enough anymore?
There was a problem hiding this comment.
Somehow I thought ... was idiomatic for @abstractmethod but a second search seems to show the community is split 🤷 .
I'll take your approval as an indication you are OK with it :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional typing in rptest.
Most changes are pure typing, but there a few asserts etc added here and there to satisfy the type checking. No intentional functional changes.
Backports Required
Release Notes