Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-2741] Client Quotas: support dynamic rate configuration #18693

Merged
merged 3 commits into from
May 30, 2024
Merged

[CORE-2741] Client Quotas: support dynamic rate configuration #18693

merged 3 commits into from
May 30, 2024

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented May 29, 2024

Client quota configuration is now dynamic.

Previously, changes to the rate would not be taken into account for existing tracked clients.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • Client qroup quotas now support dynamic configuration of the rate.

@BenPope
kafka/quota_mgr: Add configuration tests
cdefaa5 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope requested review from pgellert and a team May 29, 2024 11:15
@BenPope BenPope self-assigned this May 29, 2024
@BenPope BenPope requested review from a team, oleiman and pgellert and removed request for a team and pgellert May 29, 2024 11:17
pgellert
pgellert reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@pgellert pgellert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only, but otherwise the approach looks good to me

src/v/kafka/server/quota_manager.h Show resolved Hide resolved
src/v/kafka/server/quota_manager.cc Show resolved Hide resolved
src/v/kafka/server/tests/quota_manager_test.cc Show resolved Hide resolved
src/v/kafka/server/quota_manager.cc Show resolved Hide resolved
src/v/kafka/server/quota_manager.cc Show resolved Hide resolved
oleiman
oleiman reviewed May 29, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. couple of small things and a question about tests.

src/v/kafka/server/quota_manager.h Show resolved Hide resolved
src/v/kafka/server/quota_manager.cc Outdated Show resolved Hide resolved
src/v/kafka/server/tests/quota_manager_test.cc Show resolved Hide resolved
@BenPope
kafka/quota_mgr: Minor cleanup
4a221bc 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope force-pushed the quotas/dynamic-client-config branch from 06fcf7d to 052e7d8 Compare May 30, 2024 07:01
@BenPope
kafka/quota_mgr: Support dynamic configuration
b8216f1 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope force-pushed the quotas/dynamic-client-config branch from 052e7d8 to b8216f1 Compare May 30, 2024 07:05
@BenPope BenPope requested review from pgellert and oleiman May 30, 2024 07:06
oleiman
oleiman approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/v/kafka/server/tests/quota_manager_test.cc Show resolved Hide resolved
@BenPope BenPope merged commit 8e58103 into redpanda-data:dev May 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgellert pgellert pgellert approved these changes

@oleiman oleiman oleiman approved these changes

Assignees

@BenPope BenPope

Labels
area/kafka area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenPope @oleiman @pgellert