Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kubectl client to support Azure and capture tbot output #18757

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update Kubectl client to support Azure and capture tbot output #18757

merged 2 commits into from
Jun 7, 2024

Conversation

rpdevmp
Copy link
Contributor

@rpdevmp rpdevmp commented Jun 1, 2024 •
edited by clee
Loading

Update Kubectl client to support Azure and capture tbot output

Fixes PESDLC-1433

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@rpdevmp rpdevmp requested review from savex, travisdowns and clee and removed request for savex and travisdowns June 1, 2024 05:40
clee
clee reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly okay except for one thing, maybe could be improved?

tests/rptest/clients/kubectl.py Show resolved Hide resolved
savex
savex reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small comment on logging in case of rc!=0

tests/rptest/clients/kubectl.py Show resolved Hide resolved
@rpdevmp rpdevmp requested a review from savex June 6, 2024 20:40
savex
savex approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jun 6, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49975#018fef86-3546-41f6-b16a-fda82f531f7f

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49975#018fef86-3543-462a-bd55-43b95a97a137

@rpdevmp rpdevmp merged commit 90b0cb6 into dev Jun 7, 2024
16 checks passed
@rpdevmp rpdevmp deleted the prdevmp/PESDLC-1433 branch June 7, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

@savex savex savex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpdevmp @vbotbuildovich @clee @savex