CORE-3167 relax fips enabled behavior #18766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
requested review from
a team,
andijcr and
graphcareful
and removed request for
a team
|
Just out of curiosity. Why not use |
Because a user will be the one setting the |
micheleRP
reviewed
Jun 4, 2024
micheleRP
reviewed
Jun 4, 2024
graphcareful
previously approved these changes
Jun 4, 2024
andijcr
previously approved these changes
Jun 4, 2024
Signed-off-by: Michael Boquard <michael@redpanda.com>
Signed-off-by: Michael Boquard <michael@redpanda.com>
This ensures that a test that wishes to override the FIPS mode flag doesn't get that overwritten later. Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
dismissed stale reviews from andijcr, graphcareful, and micheleRP
via
ea62122
michael-redpanda
force-pushed
the
CORE-3167-Relax-fips-enabled
branch
from
b150e14 to
ea62122
Compare
|
Force push
|
graphcareful
reviewed
Jun 4, 2024
| }) | ||
|
|
||
| @cluster(num_nodes=3) | ||
| def test_startup(self): |
There was a problem hiding this comment.
Maybe parameterize by mode, adding testing capability to ensure it crashes when expected in enabled mode as well
There was a problem hiding this comment.
Filed as a todo: https://redpandadata.atlassian.net/browse/CORE-3194
When RP is not installed to /opt/redpanda, some of the config files will point to non-existant files. This change will make it so one can run Redpanda in FIPS mode in DT. Signed-off-by: Michael Boquard <michael@redpanda.com>
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
CORE-3167-Relax-fips-enabled
branch
from
ea62122 to
82b4733
Compare
|
Force push
|
andijcr
approved these changes
Jun 5, 2024
graphcareful
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the
fips_modenode config flag:boolto anenumdisabled- FIPS mode disabledenabled- FIPS mode enabled and/proc/sys/crypto/fips_enabledmust equal1or Redpanda will exitpermissive- FIPS mode enabled and/proc/sys/crypto/fips_enabledis checked for1but if not1, Redpanda will log a warningBackports Required
Release Notes