-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging around topic creation and update topic properties events #18789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor questions but LGTM!
7fc8186
to
c53454c
Compare
34c9b65
to
979ea1e
Compare
@graphcareful - is the self test stuff related to this PR? or accidental push maybe? |
Oh I force pushed to the wrong branch! Will fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for docs
979ea1e
to
c53454c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions
c53454c
to
47c26f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
On the node serving the request, the result of
create_topics
requests andalter_configs
requests will be logged. Errors will be logged at theWARN
levelJIRA Link: https://redpandadata.atlassian.net/browse/CORE-1355
Backports Required
Release Notes
Improvements