Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging around topic creation and update topic properties events #18789

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

graphcareful
Copy link
Contributor

@graphcareful graphcareful commented Jun 5, 2024

On the node serving the request, the result of create_topics requests and alter_configs requests will be logged. Errors will be logged at the WARN level

JIRA Link: https://redpandadata.atlassian.net/browse/CORE-1355

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • Improved logging around create_topics and alter_configs requests

oleiman
oleiman previously approved these changes Jun 5, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor questions but LGTM!

src/v/kafka/server/handlers/create_topics.cc Outdated Show resolved Hide resolved
src/v/kafka/server/handlers/create_topics.cc Outdated Show resolved Hide resolved
src/v/kafka/server/handlers/create_topics.cc Outdated Show resolved Hide resolved
oleiman
oleiman previously approved these changes Jun 5, 2024
@oleiman
Copy link
Member

oleiman commented Jun 5, 2024

@graphcareful - is the self test stuff related to this PR? or accidental push maybe?

@graphcareful
Copy link
Contributor Author

@graphcareful - is the self test stuff related to this PR? or accidental push maybe?

Oh I force pushed to the wrong branch! Will fix

micheleRP
micheleRP previously approved these changes Jun 6, 2024
Copy link

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for docs

Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions

src/v/kafka/server/handlers/create_topics.cc Outdated Show resolved Hide resolved
src/v/kafka/server/handlers/create_topics.cc Outdated Show resolved Hide resolved
src/v/kafka/server/handlers/configs/config_utils.h Outdated Show resolved Hide resolved
Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@graphcareful graphcareful merged commit d9d08b8 into redpanda-data:dev Jun 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants