golang SDK: Introduce serde opts for subject auto(ish)-creation #19823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
force-pushed
the
xform/sdk/core-3123/auto-output-subject-schema
branch
4 times, most recently
from
bb94ffe to
05e6205
Compare
oleiman
requested review from
a team,
aanthony-rp and
michael-redpanda
and removed request for
a team
aanthony-rp
previously requested changes
Jun 14, 2024
Includes unit tests. The primary purpose here is to generate a correct subject name based on user-provided topic and/or record names. Users may include a nameless function, parameterized by the derived subject name, where they can perform the actual creation of the subject version in SR. The idea here is to keep Serde[T] more ore less decoupled from the particular schema it's working on while avoiding repeated, error prone subject name generation code all over the place in user transforms. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> o
For the golang version:
Add a (useless) ValueSubjectTopicName for the input topic.
Previously, this transform created the schema it needs in the main function,
looking it up by ID and adding to the Serde instance.
The new version moves the subject creation logic to the Serde.Register call,
adding a ValueSubject to produce that effect. This has no functional effect
on the transform and is not something a user would normally do. It is meant
only to confirm that {Key,Value}Subject is working and not interfering with
normal operation.
For the rust version:
Instead of creating subject "demo-topic-value", create "avro-value" so that
we can check the effect of the golang version in integration_test.go. This
also has no functional effect on the test transform.
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
oleiman
force-pushed
the
xform/sdk/core-3123/auto-output-subject-schema
branch
from
06267e2 to
e91efdd
Compare
michael-redpanda
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit tests.
The primary purpose here is to generate a correct subject name based
on user-provided info:
Users may include a nameless function, parameterized by the derived
subject name, where they can perform the actual creation of the subject
version in SR. The idea here is to keep Serde[T] more ore less decoupled
from the particular schema it's working on.
Closes CORE-3123
Backports Required
Release Notes
Improvements