[v24.1.x] rpk: Improve k8s bundle errors + better admin API fallback #19878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time this step fails due to a permission error. (cherry picked from commit 87927b3)
If a user provides a configuration file without redpanda.data_directory, rpk won't know where to find the controller log dirs. We now provide a better error message instead of: * lstat redpanda/controller/0_0: no such file or directory Either way, a configuration file (redpanda.yaml) without a data_directory is an invalid config file, (cherry picked from commit 3ec0d6c)
When a command fails to run, rpk will return: - couldn't save 'foo.txt': exit status 1 And will save stderr in foo.txt for full debugging. This is not clear, so users may be lost about what happened and won't know how to get pass this error. We are adding a hint of where is the rest of the error (which might be multiple lines of text) (cherry picked from commit 63a367e)
Clusters deployed with helm/operator will now have the rpk section of the redpanda.yaml filled with the Admin API addresses of the cluster. We fallback to these addresses in case rpk can't discover the API addresses using the k8s API. (cherry picked from commit 865af17)
Now we want to check if the authenticated user account has authorization to collect the k8s resources needed for the debug bundle process. If not, we avoid running all the steps and instead providing a single, meaningful error message with a hint on how to solve this (link to our docs). (cherry picked from commit e779bf3)
r-vasquez
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #19473
Fixes: #19877,