[v24.1.x] Refined leadership changed metrics #19891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the leadership changed metric was incremented every time a group leader was updated with the new leader or the leader was currently unknown. Technically the change from leader to no leader is a leadership change but it was confusing to users. Change the metric updates to only account the changes when leader is present. This way after each successful leader election the metric is incremented by one on all partition replicas. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 5bee838)
Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 501eaed)
|
unrelated ci failure: #19933 |
mmaslankaprv
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #19873