raft: fix changing raft_election_timeout_ms without restart #19899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
force-pushed
the
nv/raft-timeout-lr
branch
from
4788d9e to
779e7ba
Compare
Previously the watch callback was set on the binding which didn't leave past the constructor so it was never called.
nvartolomei
force-pushed
the
nv/raft-timeout-lr
branch
from
779e7ba to
447cabd
Compare
|
new failures in https://buildkite.com/redpanda/redpanda/builds/50493#019036b7-e347-4836-9c18-29795b2fc60d: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50493#019036d1-a9be-444b-9703-91be6b146895 |
|
The CI failure looks unrelated. test_leadership_transfer: rptest.services.metrics_check.MetricCheckFailed: MetricCheckFailed<vectorized_raft_leadership_changes_total old=0.0 new=0.0> |
mmaslankaprv
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes