[CORE-3008] schema_registry: Improve handling of deleted schema #19944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store::get_versions was ignoring include_deleted, which meant that the new schema was detected as existing, but not a candidate for being added as a new version. A test was fixed up, as schema id 1 is not compatible with id v2, compatibility must be set to NONE before adding back id 1, as it will become version 3. Signed-off-by: Ben Pope <ben@redpanda.com>
michael-redpanda
previously approved these changes
Jun 21, 2024
|
new failures in https://buildkite.com/redpanda/redpanda/builds/50515#01903b21-9061-476d-b31d-cf831d8141b2: |
andijcr
previously approved these changes
Jun 24, 2024
When the last version is soft-deleted, the config should be cleared. Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
dismissed stale reviews from andijcr, pgellert, and michael-redpanda
via
4261670
BenPope
force-pushed
the
schema_registry/delete_version
branch
from
7ed6b9a to
4261670
Compare
|
Changes in [force-push]
|
pgellert
approved these changes
Jun 24, 2024
andijcr
approved these changes
Jun 24, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store::get_versionswas ignoringinclude_deleted, which meant thatthe new schema was detected as existing, but not a candidate for
being added as a new version.
A test was fixed up, as schema id 1 is not compatible with id v2,
compatibility must be set to NONE before adding back id 1, as it
will become version 3.
When the last version is soft-deleted, the config should be cleared.
Backports Required
Release Notes
Bug Fixes