Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: improve help text and minor bug fix #19948

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

r-vasquez
Copy link
Contributor

This brings the documentation changes from https://github.com/redpanda-data/docs/pull/559/files to rpk codebase.

Also fixes a bug that prevented --any-port from working with console when using a cluster with more than 1 node.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Bug Fixes

  • rpk: fixed a bug that prevented --any-port from working with Redpanda Console when using a cluster with more than 1 node.

twmb
twmb previously approved these changes Jun 21, 2024
kbatuigas
kbatuigas previously approved these changes Jun 24, 2024
Copy link

@kbatuigas kbatuigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggested edits but no blockers otherwise

src/go/rpk/pkg/cli/container/start.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/container/start.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/container/start.go Outdated Show resolved Hide resolved
@r-vasquez r-vasquez dismissed stale reviews from kbatuigas and twmb via 49f2160 June 24, 2024 17:59
@r-vasquez r-vasquez force-pushed the container-help-text branch from c32958f to 49f2160 Compare June 24, 2024 17:59
We were using the incorrect port when
configuring the addresses in the Console
configuration file, it made using the
--any-port not possible with Redpanda Console.
@r-vasquez r-vasquez force-pushed the container-help-text branch from 49f2160 to 7fb56fc Compare June 24, 2024 18:00
@r-vasquez r-vasquez merged commit 5a4550f into redpanda-data:dev Jun 25, 2024
22 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@r-vasquez r-vasquez deleted the container-help-text branch July 3, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants