CORE-4263 Removed any use of GnuTLS #20129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-redpanda
requested review from
aanthony-rp
and removed request for
a team
michael-redpanda
force-pushed
the
CORE-4263-Remove-unused-libs
branch
from
68cbabf to
5a6232e
Compare
|
Depends on: https://github.com/redpanda-data/vtools/pull/2884 Edit: actually the vtools depends on this. |
michael-redpanda
requested review from
dotnwat and
oleiman
and removed request for
aanthony-rp
|
Any of this relevant @michael-redpanda ? $ git grep gnutls
install-dependencies.sh: gnutls-dev
install-dependencies.sh: gnutls-devel
licenses/third_party.md:| gnutls | LGPL v2.1 |
src/v/cloud_storage_clients/configuration.cc: // NOTE: this is a pre-defined gnutls priority string that
tests/rptest/services/utils.py: # '2024-04-11T17:05:13.758476896Z stderr F WARN 2024-04-11 17:05:13,755 [shard 0:main] seastar_memory - oversized allocation: 217088 bytes. This is non-fatal, but could lead to latency and/or fragmentation issues. Please report: at 0x80ddafb 0x7de622b 0x7df04bf /opt/redpanda/lib/libgnutls.so.30+0xc5ca3 /opt/redpanda/lib/libgnutls.so.30+0x12a9e3 /opt/redpanda/lib/libgnutls.so.30+0x813df 0x80906ef 0x7f66333' |
michael-redpanda
force-pushed
the
CORE-4263-Remove-unused-libs
branch
from
5a6232e to
d9e0735
Compare
Thanks! |
|
Force push Remove some last vestiges of GnuTLS |
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
CORE-4263-Remove-unused-libs
branch
from
d9e0735 to
869b4aa
Compare
|
Force push
|
oleiman
reviewed
Jun 25, 2024
Comment on lines
-25
to
-27
| template<gnutls_mac_algorithm_t Algo, size_t DigestSize> | ||
| class hmac { | ||
| static_assert(DigestSize > 0, "digest cannot be zero length"); |
There was a problem hiding this comment.
Question about this removal, mostly for my own benefit - so in effect this validation is already done to our satisfaction and we can remove this? Or there's more work to do there and we'll build off an old commit?
There was a problem hiding this comment.
I'm good with the bench results. Just left it in until we fully pulled gnutls
There was a problem hiding this comment.
Cool, yeah. I just haven't been following along I guess 😕
dotnwat
reviewed
Jun 25, 2024
| @@ -20,7 +20,6 @@ please keep this up to date with every new library use. | |||
| | DPDK | BSD | | |||
| | fmt | BSD | | |||
| | gmp | LGPL v3 | | |||
| | gnutls | LGPL v2.1 | | |||
There was a problem hiding this comment.
should nettle, gmp, etc... also be removed from this list?
There was a problem hiding this comment.
Thanks, yup
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
CORE-4263-Remove-unused-libs
branch
from
869b4aa to
30af579
Compare
BenPope
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes