Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud_storage: path-related non-functional changes #20144

Merged
merged 2 commits into from
Jun 26, 2024
Merged

cloud_storage: path-related non-functional changes #20144

merged 2 commits into from
Jun 26, 2024

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Jun 25, 2024

  • moves segment runs out of archival/types (it has some path-related business logic in it that will need to change, and it's better for that to be in its own file)
  • add a new upload_manifest() interface that allows callers to pick the path, to be used in a future PR

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@andrwng
cloud_storage: add upload_manifest with path arg
62224d6 
I have some upcoming changes that move ownership of deciding a path to a
centralized location. To that end, the cloud_storage::remote will have
less ssay in the path names of manifests.

This commit is a small foundational change to expose an upload_manifest
call in which callers can determine the path. Later changes will begin
using this more extensively, and eventually the call where remote picks
a name will be removed.
@andrwng
archival: pull out adjacent segment run
6945e4d 
There's some business logic in archival/types to generate path names. In
the effort to change how we assign paths to objects, this moves that
musiness logical out of archival/types, so that the business logic
doesn't need to muddy such a fundamental file.
@andrwng andrwng force-pushed the labels-non-functional branch from c04ae81 to 6945e4d Compare June 25, 2024 21:14
@andrwng andrwng requested review from dotnwat and Lazin June 26, 2024 02:24
@dotnwat dotnwat merged commit fc80eab into redpanda-data:dev Jun 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@Lazin Lazin Awaiting requested review from Lazin

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrwng @dotnwat