Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fixed querying new leader node in leadership transfer test #20378

Merged
merged 2 commits into from
Jun 27, 2024
Merged

tests: fixed querying new leader node in leadership transfer test #20378

merged 2 commits into from
Jun 27, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Jun 27, 2024 •
edited
Loading

The test was using an api expecting the node ordinal to query for the node that was elected as a leader. The query was based on the node id. This lead to the validation being invalid.

Fixes: #19953

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@mmaslankaprv
tests: fixed querying new leader node in leadership transfer test
b455334 
The test was using an api expecting the node ordinal to query for the
node that was elected as a leader. The query was based on the node id.
This lead to the validation being invalid.

Fixes: redpanda-data#19953

Signed-off-by: Michał Maślanka <michal@redpanda.com>
ztlpn
ztlpn previously approved these changes Jun 27, 2024
View reviewed changes
@bashtanov
Copy link
Contributor

Above your change there are quite a few calls to self.redpanda.get_node(). Some of them use a value obtained from the first component of self._wait_for_leader() result as well. Aren't they subject to the same problem?

@mmaslankaprv
Copy link
Member Author

Above your change there are quite a few calls to self.redpanda.get_node(). Some of them use a value obtained from the first component of self._wait_for_leader() result as well. Aren't they subject to the same problem?

good point, i've changed all the places to get_node_by_id

@mmaslankaprv mmaslankaprv requested a review from ztlpn June 27, 2024 12:47
@mmaslankaprv
tests: use get_node_by_id in raft availability test
205b9fa 
Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv merged commit e04688d into redpanda-data:dev Jun 27, 2024
16 checks passed
@mmaslankaprv mmaslankaprv deleted the fix-19953 branch June 27, 2024 16:19
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

This was referenced Jun 27, 2024
Closed
Merged
Closed
Merged
@mmaslankaprv
Copy link
Member Author

fixes: #20574

@mmaslankaprv mmaslankaprv mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashtanov bashtanov bashtanov approved these changes

@bharathv bharathv Awaiting requested review from bharathv

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (MetricCheckFailed) in RaftAvailabilityTest. test_leadership_transfer
4 participants
@mmaslankaprv @bashtanov @vbotbuildovich @ztlpn