rp_storage_tool: account for labels #20584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
force-pushed
the
labels-rp-storage-tool
branch
from
7a48a1a to
bcfba27
Compare
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
abhijat
reviewed
Jun 28, 2024
|
/dt |
Upcoming changes will enable supplying a cluster UUID to a topic to change the remote paths that get used. To account for this, this changes rp_storage_tool to look for the new path format and collect the cluster UUID labels. This will allow us to continue running rp_storage_tool in ducktape tests once the feature is enabled.
andrwng
force-pushed
the
labels-rp-storage-tool
branch
from
bcfba27 to
81c09d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming changes will enable supplying a cluster UUID to a topic to change the remote paths that get used. To account for this, this changes rp_storage_tool to look for the new path format and collect the cluster UUID labels. This will allow us to continue running rp_storage_tool in ducktape tests once the feature is enabled.
The high level approach taken here is to collect and serialize labels as a part of the NTPR and NTR objects that are associated with objects and anomalies. The label is optional, and a None label will refer to hash-prefixed objects.
This has change has been seen to allow CI to pass in a feature branch I'm working in: https://buildkite.com/redpanda/redpanda/builds/50695#_
Backports Required
Release Notes