[CORE-4878] [v23.3.x] http: change stop() to shutdown() on TLS errors in client (manual backport)
#20589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would call `client::stop()` upon encountering TLS errors in `client::send_some()`, `client::recv_some()` and `client::make_request()`. These stopped `client`s would not be removed from the `client_pool`, resulting in erroneous use for future requests. Change the default behavior from calling `stop()` to `shutdown()`, which leaves `client` in a usable state for the future, after a connection is re-attempted. Also improve logging around TLS errors, `_connect_gate`, and add checks around the state of `_stopped` in `client::make_request()` and `get_connected()`. (cherry picked from commit b6621fe)
andrwng
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Looks functionally the same. I'm guessing the conflicts were just from the header for likely.h changing, is that right @WillemKauf ?
Correct, that was the only diff preventing a seamless cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would call
client::stop()upon encountering TLS errors inclient::send_some(),client::recv_some()andclient::make_request(). These stoppedclients would not be removed from theclient_pool, resulting in erroneous use for future requests.Change the default behavior from calling
stop()toshutdown(), which leavesclientin a usable state for the future, after a connection is re-attempted.Also improve logging around TLS errors,
_connect_gate, and add checks around the state of_stoppedinclient::make_request()andget_connected().(cherry picked from commit b6621fe)
Fixes #20588
Backports Required
Release Notes