ssx/single_sharded: improve argument and ret val processing, improve tests #20806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests - make argument processing consistent with ss::sharded<Service>::invoke_on, i.e. make them value moved or copied even if lvalue was provided, and only pass on a reference via std::reference_wrapper - accept a pointer to method as a callable - tidy up the tests
bashtanov
requested review from
dotnwat,
andijcr,
bharathv,
ztlpn and
mmaslankaprv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ss::sharded<Service>::invoke_on, i.e. make them value moved or copied even if lvalue was provided, and only pass on a reference via std::reference_wrapperss::sharded<Service>::invoke_onis weird indeed, as itSince it doesn't bother anyone let's mimic its quirks to reduce the surprise at least for those aware of them.
Backports Required
Release Notes