rpk: add support to produce/consume with jsonschema #20820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-redpanda
previously approved these changes
Jul 3, 2024
r-vasquez
force-pushed
the
jsonschema-serde
branch
from
1414ae9 to
86078b4
Compare
gene-redpanda
approved these changes
Jul 3, 2024
twmb
reviewed
Jul 3, 2024
Comment on lines
+51
to
+57
| // Append the magic byte + the schema ID bytes. | ||
| var serdeHeader sr.ConfluentHeader | ||
| h, err := serdeHeader.AppendEncode(nil, schemaID, nil) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to append header: %v", err) | ||
| } | ||
| return append(h, record...), nil |
There was a problem hiding this comment.
Not worth it in this PR, but I wonder if we can have a fast follow up commit that does this prefix appending in a wrapper function in pkg/serde/serde.go
twmb
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now rpk support "encoding" and "decoding" records using JSON schemas in the schema registry. rpk will validate the record before decoding or encoding it.
Along with #19947 and #20757 this completes the support of JSON schemas in rpk.
Backports Required
Release Notes
Features
rpk registryandrpk topic produce/consume