Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: foundation #20849
bazel: foundation #20849
Changes from all commits
7eebf73
281b8c9
9895d33
39d3d9a
61a0fe1
65ffd83
80802ae
e5aa44f
06ff960
b90e0ca
2b47fbd
b8d3ed2
e8efde5
6826627
e2fcf0a
be287e1
e58bd47
f9319a1
82e7954
4e96dcc
bbfde7d
9a1f8e6
b52e2a7
169f910
ddd4cbd
cc035b8
01abe7a
0bbd40e
075f5eb
1fcd770
fad3b00
d698141
329d13a
590810f
a89af08
ca22e2b
2887843
f5da85d
f2ec24e
b5d51b7
ed9ba45
ad42e34
ee8e91d
ecc8b4d
5819f3c
5563372
b4e9c43
4080858
fa29de0
8007cc2
745a230
2f255c9
0f7fd32
5305841
a7e178f
9bc2053
fed5d40
b813457
d61347e
22bc0c0
538f55a
21b9683
53a08f3
e41c776
52e690b
f193188
ea828bc
baa87be
4302062
f9678d2
dbc06de
7cefc24
83c1c21
c2db0a8
69110a4
a79fb21
8912807
97a9e9a
5dcaaf5
a9b8a88
29982fe
ec7a722
1f5145b
956faf7
f5a2039
8958c57
f1c0574
0e3c42d
4505f93
d5e38a1
20ec04c
00e29d5
8b74a72
f862f7b
b813371
e6d916a
8484270
7985abd
52d8d53
be81892
1554594
eeeda55
aecf8d1
dbadf9b
7304569
107ed92
95a8172
023445c
ff8a6ae
65e2f6d
20be636
68c5582
2f5dc42
c2d71fb
5393109
4281447
c83f8f4
68cd642
f03a6e0
0dece98
3149a21
14c4467
34e9296
786c500
4cd0421
42e5112
f28c1e1
79739bc
611c3a4
c9ad3c5
fd0708b
1c3c9d4
a328dd2
fa58be8
0b791cf
03fce37
71fbdd0
d6e4759
b06999a
2652fb4
1a62646
d2e3911
47b1f9c
bc92998
fe2a1a0
901d957
347fec7
65cdb82
219b14c
b6ba4c9
86f4e30
73de59c
a190314
ef3055e
7c0a385
f626e11
5e7d428
24f2079
4d952e0
c091280
69699d0
b7ceb49
be1d2d9
0f2faf6
0bf26e2
65c4600
134f6b7
99abab1
6b3bc74
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? https://registry.bazel.build/modules/rapidjson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The published version appears to be too old. I added a note into MODULE.bazel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG - FWIW you can override the version much like we are doing for the compilation commands database generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see this pattern, and it always seems super sketchy. like, IIUC, it effectively uses the BUILD files from BCR and source files from whatever version you swap in for the override? i mean, it works fine for a header-only library, assuming that the BUILD uses globbing. Generally I'd want the BUILD to be perfectly in sync with the source...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe we should just be proposing updates upstream. Let me read about how dependency resolution works with non modules