Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix headers #21287

Merged
merged 4 commits into from
Jul 7, 2024
Merged

chore: fix headers #21287

merged 4 commits into from
Jul 7, 2024

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jul 7, 2024

  • Adds outcome future utils to base library
  • Narrows scope of serde includes
  • Removes unused header
  • Adds missing includes guard

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

dotnwat added 4 commits July 7, 2024 08:11
It needs a home.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Including serde/serde.h enables serde for all supported types, but comes
at the expense of unused headers and dependency issues for stricter
build systems.

Instead, include only what is required.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat dotnwat changed the title WIP chore: fix headers Jul 7, 2024
@dotnwat dotnwat merged commit 49bfbf3 into redpanda-data:dev Jul 7, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants