-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpk: add rpk cluster quotas import
#21311
Conversation
This type should be singular since it represent a single key:value pair of a quota value.
From a user perspective I would prefer to see what's the acceptable schema in this help text. However I can understand from a development/design perspective that the schema can change and the source will be the command that generates it. Considering the above, can we include the acceptable schema in this help text? If not, it's fine. I defer to you guys what's the best approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some updates for active voice/clarity.
2b20019
to
8a03c55
Compare
Force Push: After internal discussion:
|
This new command will let user to import quotas from other clusters by using the same format of `rpk cluster quotas describe --format <json/yaml>` rpk will read and issue the alterClusterQuota request.
8a03c55
to
6dd45a2
Compare
This PR introduces a new command:
rpk cluster quotas import
Usage:
import
uses a string source that should be formatted as the output ofrpk cluster quotas describe --format <json/yaml>
. It accepts either the string, or a file containing the json (or yaml) representation of the import source:The command issues an alterQuotas request, deleting the old quotas, hence, a confirmation prompt is needed:
Backports Required
Release Notes
Features
rpk cluster quotas import
.