Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k/group: do not log ignoring raft configuration batches #21410

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mmaslankaprv
Copy link
Member

Raft configuration batches are integral part of Raft managed log. Emitting warn log message that Redpanda ignore them when parsing consumer group state machine data may be confusing as this is expected and not something that the users should worry about.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Raft configuration batches are integral part of Raft managed log.
Emitting warn log message that Redpanda ignore them when parsing
consumer group state machine data may be confusing as this is expected
and not something that the users should worry about.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
Copy link
Contributor

@bashtanov bashtanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I wonder why not have a switch instead of all these ifs

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jul 15, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/51517#0190b6a8-3b83-4f65-b68e-f60f2babf17c:

"rptest.tests.rack_aware_replica_placement_test.RackAwarePlacementTest.test_rack_awareness_after_node_operations.rack_layout=ABCDEF"

new failures in https://buildkite.com/redpanda/redpanda/builds/51517#0190b6a8-3b89-4575-9130-63bbdd697e24:

"rptest.tests.write_caching_fi_test.WriteCachingFailureInjectionTest.test_leader_epoch"

new failures in https://buildkite.com/redpanda/redpanda/builds/51566#0190ba4a-b7f3-4855-b93a-3d54df09126b:

"rptest.tests.scaling_up_test.ScalingUpTest.test_fast_node_addition"

@mmaslankaprv
Copy link
Member Author

/ci-repeat 1

@mmaslankaprv
Copy link
Member Author

unrelated ci failure: #20224

@mmaslankaprv mmaslankaprv merged commit 8791fde into redpanda-data:dev Jul 17, 2024
16 of 20 checks passed
@mmaslankaprv mmaslankaprv deleted the group-logging-fix branch July 17, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants