Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: make mechanism flag required in user update #21452

Merged
merged 1 commit into from
Jul 18, 2024
Merged

rpk: make mechanism flag required in user update #21452

merged 1 commit into from
Jul 18, 2024

Conversation

r-vasquez
Copy link
Contributor

Without this, a user could inadvertently change the mechanism because we default the flag to
SCRAM-SHA-256.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • rpk: --mechanism flag is now required to update users when using rpk security user update.

twmb
twmb previously approved these changes Jul 17, 2024
View reviewed changes
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jul 17, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/51612#0190be5d-4556-4861-ac06-fd2aef2a9710:

"rptest.tests.rpk_acl_test.RpkACLTest.test_create_update"

new failures in https://buildkite.com/redpanda/redpanda/builds/51612#0190be5d-4551-4e07-8528-c460a31a8dfd:

"rptest.transactions.tx_atomic_produce_consume_test.TxAtomicProduceConsumeTest.test_basic_tx_consumer_transform_produce.with_failures=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/51612#0190be5e-f787-4745-9365-7aa38c04d8af:

"rptest.tests.rpk_acl_test.RpkACLTest.test_create_update"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jul 17, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51612#0190be5d-4554-4b73-b5a3-e82a80669eb8

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51612#0190be5d-4551-4e07-8528-c460a31a8dfd

@r-vasquez
rpk: make mechanism flag required in user update
07943e6 
Without this, a user could inadvertently change the
mechanism because we default the flag to
SCRAM-SHA-256.
@r-vasquez
Copy link
Contributor Author

Force Push: update Ducktape test with the new flag

@r-vasquez
Copy link
Contributor Author

Unrelated timeout in rp unit test: https://buildkite.com/redpanda/redpanda/builds/51661#0190c152-5853-420f-9edc-a56ad06124f1/6-11162 is #18563

@twmb twmb merged commit f8bc2f8 into redpanda-data:dev Jul 18, 2024
20 of 23 checks passed
@r-vasquez
Copy link
Contributor Author

/backport v24.1.x

@r-vasquez
Copy link
Contributor Author

/backport v23.3.x

@r-vasquez
Copy link
Contributor Author

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

This was referenced Jul 19, 2024
Closed
Closed
Closed
Merged
Merged
Merged
@r-vasquez r-vasquez deleted the patch-update-acl branch September 9, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-vasquez @vbotbuildovich @twmb