rpk/transform/build: fix js sdk tooling #21490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
requested review from
twmb,
r-vasquez,
gene-redpanda and
Deflaimun
as code owners
Mac builds dynamically link the executable instead of static linking on linux. Make sure the mac builds include the required dylib (in the right directories too so rpath fiddling is not needed). I packaged a new toolchain using `package_toolchain.py`, uploaded that to the tinygo repo (still need a better place to upload that stuff), and fixed the paths now that they changed in the tarball.
oleiman
approved these changes
Jul 17, 2024
r-vasquez
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac builds dynamically link the executable instead of static linking on
linux. Make sure the mac builds include the required dylib (in the right
directories too so rpath fiddling is not needed).
I packaged a new toolchain using
package_toolchain.py, uploaded thatto the tinygo repo (still need a better place to upload that stuff), and
fixed the paths now that they changed in the tarball.
Fixes: CORE-5594
Backports Required
Release Notes
Bug Fixes