iceberg: utils for operating on avro #21493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit added a test that defined some Avro serialization utilites. These will be useful outside of tests, since it's generally common for other parts of Redpanda to use iobufs as the in-memory buffer of choice.
When using a DataFile{Writer,Reader}, we'll need to be able to pass the
buffer used by the writer. This is difficult to do with the current
interface of avro_iobuf_ostream, which is std::moved into the writer.
So, this moves the buffer outside of the ostream, which makes it easier
for callers to manage the iobuf.
Note, it doesn't appear the trimming I was doing on release() was needed
after all.
Adds a simple test for serializing manifest files with a DataFileWriter and reading it back with a DataFileReader. This is will ultimately be what we'll use to serialize manifests, since the DataFileWriter is what will write additional metadata[1][2] (like the Iceberg schema). [1] https://github.com/redpanda-data/avro/blob/1410e79f9df61669c2d52f6d0643e6c35156e615/lang/c%2B%2B/impl/DataFile.cc#L246-L252 [2] https://iceberg.apache.org/spec/#manifests
andrwng
force-pushed
the
iceberg-avro-utils
branch
from
af65819 to
011cae1
Compare
dotnwat
approved these changes
Jul 18, 2024
Comment on lines
+32
to
+33
| iobuf buf; | ||
| auto out = std::make_unique<avro_iobuf_ostream>(4096, &buf); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out some utilities that were previously used in tests. We will need to be able to read and write Avro files (this is the format manifests and manifest lists are in).
Also makes some adjustments to be able to pass around the
iobufwhen using Avro's reader/writer classes, and adds a test demonstrating how this will be done. This test also exercises getting metadata from the Avro header, which is where e.g. the Iceberg schema will be stored in manifests[1].[1] https://iceberg.apache.org/spec/#manifests
Backports Required
Release Notes