CORE-5686 Decouple different raft group shutdown sequences #21517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
fix-CORE-5686
branch
from
dc60b08 to
7092db6
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51777#0190ca5b-e35e-43a9-9625-5d75dcf25f7e ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51787#0190cbd8-e85b-4b52-b0d3-17aee9b23af3 |
Added a log entry when partition is removed to make debugging partition shutdown issues easier. Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-CORE-5686
branch
from
7092db6 to
782aea4
Compare
ztlpn
reviewed
Jul 19, 2024
Individual raft groups shutdown operations are not correlated and do not need coordination with mutex. The `group_manager::_groups` vector is always updated in synchronous parts of code therefore it do not require the mutex either. Removed the mutex to make shutting down different Raft groups independent from each other. Fixes CORE-5686 Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-CORE-5686
branch
from
782aea4 to
e0236f6
Compare
ztlpn
approved these changes
Jul 22, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
|
Failed to create a backport PR to v24.1.x branch. I tried: |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
|
/backport v24.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual raft groups shutdown operations are not correlated and do not
need coordination with mutex. The
group_manager::_groupsvector isalways updated in synchronous parts of code therefore it do not require
the mutex either.
Removed the mutex to make shutting down different Raft groups
independent from each other.
Fixes CORE-5686
Backports Required
Release Notes