[v24.1.x] producer_state: add request::set_error and make it idempotent #21524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5fe079a)
these are supposed to be rare and typically indicate a misbehaving broker or client. (cherry picked from commit 7579cf1)
A request can be marked as errored multiple times, consider the example below. replicate_f : waiting for replication term change requests from old terms gc-ed: set_err(ec) replicate_f: set_err(ec) Current assert assumes that a request can be set only once, which is true for setting a successful result but not for errors. This commit splits set_value() into set_value() and set_error() and adjusts assert conditions accordingly. (cherry picked from commit 7719140)
ztlpn
approved these changes
Jul 22, 2024
nvartolomei
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request can be marked as errored multiple times, consider the example
below.
Current assert assumes that a request can be set only once, which is
true for setting a successful result but not for errors. This commit
splits set_value() into set_value() and set_error() and adjusts
assert conditions accordingly.
This was identified in a chaos build. Also included some logging improvements noticed while debugging, most notably printing the transaction state correctly (currently printing the pointer instead of value).
Fixes: #19841
Backports Required
Release Notes