[v23.3.x] [CORE-5671] Pandaproxy: Avoid large allocations #21557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common (especially in tests) to want to get an iobuf from a string. Adds a convenience method for this. (cherry picked from commit 06ceb0d)
From post-commit review: redpanda-data#20827 (comment) Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit d5a6516)
An optimisation when parsing a body; the read chunks should already be a suitable size. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit fac68ba)
A little drive-by fix. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit a940e07)
Disable copy for types that hold a schema definition; replacing them with an explicit `copy()` or `share()`. Also introduce a `destructure` call to avoid `bugprone-use-after-move` Fixes [CORE-1138] Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit e189e05) Conflicts: src/v/pandaproxy/schema_registry/json.cc (No JSON Schema) src/v/pandaproxy/schema_registry/requests/test/get_subject_versions_version.cc (header includes) src/v/pandaproxy/schema_registry/sharded_store.cc (No JSON Schema) src/v/pandaproxy/schema_registry/test/test_json_schema.cc (No JSON Schema) src/v/pandaproxy/schema_registry/validation.cc (an unused parameter went missing)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 1ded6e9)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 0d10035) Conflicts: src/v/json/BUILD (no bazel) src/v/json/tests/BUILD (no bazel) src/v/json/tests/json_serialization_test.cc (header includes)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 328a8b4) Conflicts: src/v/utils/base64.cc (no base64_url) src/v/utils/tests/BUILD (no bazel) src/v/utils/tests/base64_test.cc (no base64_url)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 609db2e)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 0229940)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit aa569f8)
Also fixes [CORE-684] [CORE-4446] [CORE-4447] Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit e7fab4a) Conflicts: (mostly header includes) src/v/pandaproxy/schema_registry/avro.cc src/v/pandaproxy/schema_registry/json.cc (no JSON Schemas) src/v/pandaproxy/schema_registry/protobuf.cc src/v/pandaproxy/schema_registry/storage.h src/v/pandaproxy/schema_registry/types.h src/v/pandaproxy/schema_registry/util.h
BenPope
added
area/schema-registry
BenPope
requested review from
oleiman and
andijcr
and removed request for
a team
pgellert
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21323
Fixes #21467