[v24.2.x] [CORE-5698] Fixed issue with error mapping in add_partitions_to_txn
#21585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation of transaction state transition before beginning transaction on participant data/group partitions to prevent from state inconsistencies. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 84daf51)
Changed the way how the error returned from update transaction in `do_add_parititons_to_txn` is handled. Previously every error in state update resulted in `invalid_txn_state` error. This not the case for most of the errors as client should simply retry the request. Beginning transaction on data and group partitions is idempotent so it can be safely done once again when handling request retry. Fixes: CORE-5698 Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 3ea2fe5)
mmaslankaprv
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21503