Require serde_fields for all serde structs #22782

oleiman · 2024-08-07T18:40:29Z

In effect, this PR modifies serde to require using serde_fields for all structs EXCEPT those implementing both serde_read and serde_write. In these cases envelope_to_tuple won't generally participate in overload resolution

Also adds serde_fields() to several existing structs, including those generated automatically for fuzz-testing.

Why do this? This PR provides a motivating example. Where possible, we try to avoid compat-breaking serde changes by appending new fields to the end of the binary format. The implicit coupling between aggregate field ordering and binary format makes it easy to introduce subtle serialization bugs or unnecessary compat breaks.

Backports Required

Release Notes

none

oleiman · 2024-08-07T18:41:57Z

/ci-repeat 1
release

oleiman · 2024-08-07T23:09:26Z

/ci-repeat 1

vbotbuildovich · 2024-08-08T01:42:09Z

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f5f-6009-4b03-aec1-ed4996c0a79a:

"rptest.tests.recovery_mode_test.RecoveryModeTest.test_rolling_restart"
"rptest.tests.shadow_indexing_compacted_topic_test.ShadowIndexingCompactedTopicTest.test_upload.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.S3.1.path.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.ABS.check_mode=check_manifest_and_segment_metadata"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.S3.check_mode=check_manifest_existence"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f5f-6004-42f7-9508-1976d10b810b:

"rptest.tests.shadow_indexing_compacted_topic_test.ShadowIndexingCompactedTopicTest.test_upload.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.ABS.check_mode=check_manifest_existence"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.S3.check_mode=no_check"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=-1.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f5f-6006-4028-9934-40514b596708:

"rptest.tests.cloud_storage_usage_test.CloudStorageUsageTest.test_cloud_storage_usage_reporting"
"rptest.tests.follower_fetching_test.FollowerFetchingTest.test_follower_fetching_with_maintenance_mode"
"rptest.tests.e2e_topic_recovery_test.EndToEndTopicRecovery.test_restore_with_config_batches.num_messages=2.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.ABS.2.virtual_host.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.S3.1.virtual_host.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.ABS.check_mode=no_check"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_prevent_recovery.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_time_based_retention.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=-1.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f5f-6007-482b-a8bc-53eb021338c9:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.e2e_topic_recovery_test.EndToEndTopicRecovery.test_restore_with_config_batches.num_messages=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.S3.check_mode=check_manifest_and_segment_metadata"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=1.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f60-be5f-4e6c-a136-374e8e806250:

"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off.test_mode=TestMode.FAST_MOVES.cleanup_policy=compact"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add.test_mode=TestMode.NO_TIRED_STORAGE.cleanup_policy=compact"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off.test_mode=TestMode.TIRED_STORAGE.cleanup_policy=compact"
"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.scaling_up_test.ScalingUpTest.test_moves_with_local_retention.use_topic_property=True"
"rptest.tests.simple_e2e_test.SimpleEndToEndTest.test_relaxed_acks.write_caching=True.disable_batch_cache=False"
"rptest.tests.cloud_storage_usage_test.CloudStorageUsageTest.test_cloud_storage_usage_reporting_with_partition_moves"
"rptest.tests.e2e_shadow_indexing_test.EndToEndShadowIndexingTestCompactedTopic.test_compacting_during_leadership_transfer.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=2.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=2.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.ABS.check_mode=no_check"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=1.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f60-be5b-41f7-8d04-7012a56d0c28:

"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add.test_mode=TestMode.FAST_MOVES.cleanup_policy=compact"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add.test_mode=TestMode.TIRED_STORAGE.cleanup_policy=compact"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off.test_mode=TestMode.NO_TIRED_STORAGE.cleanup_policy=compact"
"rptest.tests.partition_balancer_test.PartitionBalancerTest.test_nodes_with_reclaimable_space"
"rptest.tests.e2e_shadow_indexing_test.EndToEndShadowIndexingTestCompactedTopic.test_write.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.multi_restarts_with_archival_test.MultiRestartTest.test_recovery_after_multiple_restarts.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=0.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=0.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=-1.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.e2e_topic_recovery_test.EndToEndTopicRecovery.test_restore_with_config_batches.num_messages=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.shadow_indexing_compacted_topic_test.ShadowIndexingCompactedTopicTest.test_upload.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.S3.check_mode=check_manifest_existence"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.ABS.check_mode=check_manifest_and_segment_metadata"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f60-be61-40f3-ba20-106bfde29737:

"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off.test_mode=TestMode.FAST_MOVES.cleanup_policy=compact.delete"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add.test_mode=TestMode.NO_TIRED_STORAGE.cleanup_policy=compact.delete"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off.test_mode=TestMode.TIRED_STORAGE.cleanup_policy=compact.delete"
"rptest.tests.e2e_shadow_indexing_test.EndToEndShadowIndexingTestCompactedTopic.test_compacting_during_leadership_transfer.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.follower_fetching_test.FollowerFetchingTest.test_follower_fetching_with_maintenance_mode"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.e2e_topic_recovery_test.EndToEndTopicRecovery.test_restore_with_config_batches.num_messages=2.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.shadow_indexing_compacted_topic_test.ShadowIndexingCompactedTopicTest.test_upload.cloud_storage_type=CloudStorageType.ABS"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.S3.1.path.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.S3.check_mode=check_manifest_and_segment_metadata"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=1.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/52635#01912f60-be5d-4e61-ab1b-2ff1bf9730d0:

"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add.test_mode=TestMode.TIRED_STORAGE.cleanup_policy=compact.delete"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add.test_mode=TestMode.FAST_MOVES.cleanup_policy=compact.delete"
"rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off.test_mode=TestMode.NO_TIRED_STORAGE.cleanup_policy=compact.delete"
"rptest.tests.cloud_storage_usage_test.CloudStorageUsageTest.test_cloud_storage_usage_reporting"
"rptest.tests.e2e_shadow_indexing_test.EndToEndShadowIndexingTestCompactedTopic.test_write.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.scaling_up_test.ScalingUpTest.test_moves_with_local_retention.use_topic_property=False"
"rptest.tests.multi_restarts_with_archival_test.MultiRestartTest.test_recovery_after_multiple_restarts.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=0.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=0.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.ABS.2.virtual_host.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"
"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type_and_url_style=.CloudStorageType.S3.1.virtual_host.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.ABS.check_mode=check_manifest_existence"
"rptest.tests.topic_recovery_test.TopicRecoveryTest.test_many_partitions.cloud_storage_type=CloudStorageType.S3.check_mode=no_check"
"rptest.tests.adjacent_segment_merging_test.AdjacentSegmentMergingTest.test_reupload_of_local_segments.acks=-1.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/52977#0191550a-eb87-4aad-8a64-26539e006c3b:

"rptest.tests.leadership_transfer_test.AutomaticLeadershipBalancingTest.test_automatic_rebalance"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#0191773e-a962-47fa-9b1e-dc702a9434ca:

"rptest.tests.quota_management_test.QuotaManagementTest.test_describe_default"
"rptest.tests.self_test_test.SelfTestTest.test_self_test_mixed_node_controller_lower_version"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#0191773e-a964-490d-a17c-8ae15bc6540d:

"rptest.tests.quota_management_test.QuotaManagementTest.test_kafka_configs"
"rptest.tests.self_test_test.SelfTestTest.test_self_test_node_crash"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#0191773e-a966-4924-9ae6-4786ca3455f2:

"rptest.tests.rpk_cluster_quota_test.RpkClusterQuotaTest.test_import_describe_quotas"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#0191773e-a968-4cf0-aa45-90e910853caf:

"rptest.tests.quota_management_test.QuotaManagementTest.test_describe_any"
"rptest.tests.quota_management_test.QuotaManagementTest.test_describe_name"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#01917740-42b8-4b8a-a8b2-f49bc0c88379:

"rptest.tests.rpk_cluster_quota_test.RpkClusterQuotaTest.test_import_describe_quotas"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#01917740-42b9-4778-9f6c-14e23bce22e6:

"rptest.tests.quota_management_test.QuotaManagementTest.test_describe_any"
"rptest.tests.quota_management_test.QuotaManagementTest.test_describe_name"
"rptest.tests.self_test_test.SelfTestTest.test_self_test_mixed_node_controller_lower_version"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#01917740-42b4-47ec-b55d-ccc8baf8d67d:

"rptest.tests.quota_management_test.QuotaManagementTest.test_describe_default"
"rptest.tests.self_test_test.SelfTestTest.test_self_test_node_crash"

new failures in https://buildkite.com/redpanda/redpanda/builds/53329#01917740-42b6-4ab8-b9c1-f9a75988966e:

"rptest.tests.quota_management_test.QuotaManagementTest.test_kafka_configs"

vbotbuildovich · 2024-08-08T01:43:54Z

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52635#01912f5f-6004-42f7-9508-1976d10b810b

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52635#01912f5f-6007-482b-a8bc-53eb021338c9

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52635#01912f60-be5b-41f7-8d04-7012a56d0c28

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52780#01914326-9a3d-4dd4-91df-5f62e843d081

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53329#0191773e-a966-4924-9ae6-4786ca3455f2

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53329#01917740-42b6-4ab8-b9c1-f9a75988966e

oleiman · 2024-08-11T18:52:33Z

/ci-repeat 1

oleiman · 2024-08-15T03:40:27Z

/ci-repeat 1

oleiman · 2024-08-15T06:15:54Z

/ci-repeat 1

oleiman · 2024-08-15T18:37:40Z

CI Failure:

https://redpandadata.atlassian.net/browse/CORE-4243 (known, unrelated)

dotnwat

I wonder if we should go further and require serde_fields except for custom implementations of serde_read and serde_write. so even for single field structs?

oleiman · 2024-08-21T01:26:19Z

I wonder if we should go further and require serde_fields except for custom implementations of serde_read and serde_write. so even for single field structs?

Ha, yeah, I've been avoiding flipping this to ready for exactly that reason. Leaning towards yes; better to require it up front vs. spewing template mess on the next append.

WillemKauf · 2024-08-21T14:57:08Z

This is awesome, +1.

oleiman · 2024-08-21T19:09:29Z

/ci-repeat 1

oleiman · 2024-08-21T20:54:59Z

/ci-repeat 1
release

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

- archival_metadata_stm::segment - archival_metadata_stm::start_offset_with_delta - archival_metadata_stm::truncate_archive_commit_cmd Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

oleiman · 2024-08-21T21:52:30Z

force push to rebase dev and fix a merge conflict

oleiman · 2024-08-21T22:05:23Z

/ci-repeat 1

oleiman · 2024-08-22T01:58:46Z

CI Failures:

debug build
- quota_management_test.QuotaManagementTest.test_describe_default (~~passes locally, needs issue?~~)
- self_test_test.SelfTestTest.test_self_test_mixed_node_controller_lower_version (~~transient error?~~)
release build
- quota_management_test.QuotaManagementTest.test_describe_default (~~passes locally, needs issue?~~)
- self_test_test.SelfTestTest.test_self_test_node_crash (~~passes locally, needs issue?~~)

~~None of these seems serde related, but I'm not finding open issues for any of these...~~

oleiman · 2024-08-22T03:07:53Z

force push to fix an integration issue and a couple omissions.

dotnwat · 2024-08-22T03:09:07Z

src/v/serde/envelope_for_each_field.h

@@ -29,177 +29,6 @@ constexpr inline auto envelope_to_tuple(T&& t) {
    return t.serde_fields();
 }

-template<typename T>
-requires(!detail::has_serde_fields<T>)
-constexpr inline auto envelope_to_tuple(T& t) {


dotnwat · 2024-08-22T03:09:36Z

@felixguendling sup?

felixguendling · 2024-08-22T13:25:28Z

The general idea LGTM. Make sure to check that all necessary fields are (de)serialized when doing a code review (before this check was not necessary with "automatic mode" aka aggregate to tuple).

oleiman · 2024-08-22T16:26:02Z

CI Failure:

storage_e2e_rpfixture passes locally. flake?

WillemKauf · 2024-08-22T16:36:31Z

storage_e2e_rpfixture passes locally. flake?

Yeah, previously flakey, there was a revert PR that should fix this that got merged this AM. Re-running.

oleiman

k, i've been through this line by line, and it looks clean modulo some commit messages that have drifted out of date. @dotnwat anyone else i should tag?

oleiman · 2024-08-24T05:11:30Z

src/v/cluster/archival/archival_metadata_stm.cc

commit msg is out of date

oleiman · 2024-08-24T05:13:51Z

src/v/cluster/client_quota_serde.h

commit msg out of date

oleiman · 2024-08-24T05:16:52Z

src/v/cluster/node_status_rpc_types.h

commit msg is out of date

oleiman · 2024-08-24T05:22:06Z

src/v/model/tests/transform_test.cc

could probably fold into previous commit

dotnwat · 2024-08-26T15:50:53Z

@oleiman do you think we should add a static assert if it doesn't already exist that serde_fields xor serde_read/write are used so we don't have to think about ambiguity if both are present?

oleiman · 2024-08-26T21:09:30Z

@oleiman do you think we should add a static assert if it doesn't already exist that serde_fields xor serde_read/write are used so we don't have to think about ambiguity if both are present?

Seems like a good idea. I think in some cases we use serde_fields on the write path with explicit reader for compat reasons, but that stuff can be rejiggered as well.

Anyway, I'm going to throw this PR into draft mode and split it up. Thanks @dotnwat & @WillemKauf for feedback 🙂

oleiman · 2024-09-06T18:16:23Z

superseded by #23126 et al.

oleiman self-assigned this Aug 7, 2024

github-actions bot added the area/redpanda label Aug 7, 2024

oleiman force-pushed the serde/noticket/require-serde-fields branch from 271c030 to 9129656 Compare August 7, 2024 23:08

oleiman force-pushed the serde/noticket/require-serde-fields branch from 9129656 to 2647521 Compare August 11, 2024 18:49

oleiman force-pushed the serde/noticket/require-serde-fields branch from 2647521 to ec8276a Compare August 15, 2024 03:39

oleiman force-pushed the serde/noticket/require-serde-fields branch from ec8276a to 7070fc6 Compare August 15, 2024 06:15

dotnwat reviewed Aug 21, 2024

View reviewed changes

oleiman force-pushed the serde/noticket/require-serde-fields branch from 7070fc6 to cc40bc4 Compare August 21, 2024 19:08

oleiman force-pushed the serde/noticket/require-serde-fields branch from cc40bc4 to 2a1904c Compare August 21, 2024 20:54

oleiman added 5 commits August 21, 2024 14:21

cs: serde_fields for lifecycle_marker

e1500c1

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

cs: serde_fields for partition_manifest_serde

15d2162

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

cs: serde_fields for partition_manifest::lw_segment_meta

69606c3

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

cs: serde_fields for offset_index_header

c82c0f8

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

c/archival: serde_fields for archival_metadata_stm structs

88aa996

- archival_metadata_stm::segment - archival_metadata_stm::start_offset_with_delta - archival_metadata_stm::truncate_archive_commit_cmd Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>

oleiman force-pushed the serde/noticket/require-serde-fields branch from 2a1904c to b190447 Compare August 21, 2024 21:52

oleiman force-pushed the serde/noticket/require-serde-fields branch from b190447 to 1c0ee0f Compare August 22, 2024 03:04

oleiman marked this pull request as ready for review August 22, 2024 03:04

dotnwat reviewed Aug 22, 2024

View reviewed changes

dotnwat changed the title ~~Require serde_fields for all serde structs with arity > 1~~ Require serde_fields for all serde structs Aug 22, 2024

oleiman commented Aug 24, 2024

View reviewed changes

oleiman requested review from dotnwat and WillemKauf August 24, 2024 05:34

dotnwat requested review from BenPope, ztlpn and mikebroberg August 26, 2024 15:48

oleiman marked this pull request as draft August 26, 2024 21:11

oleiman closed this Sep 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require serde_fields for all serde structs #22782

Require serde_fields for all serde structs #22782

oleiman commented Aug 7, 2024 •

edited

Loading

oleiman commented Aug 7, 2024

oleiman commented Aug 7, 2024

vbotbuildovich commented Aug 8, 2024 •

edited

Loading

vbotbuildovich commented Aug 8, 2024 •

edited

Loading

oleiman commented Aug 11, 2024

oleiman commented Aug 15, 2024

oleiman commented Aug 15, 2024

oleiman commented Aug 15, 2024

dotnwat left a comment

oleiman commented Aug 21, 2024

WillemKauf commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 22, 2024 •

edited

Loading

oleiman commented Aug 22, 2024

dotnwat Aug 22, 2024

oleiman Aug 22, 2024

dotnwat commented Aug 22, 2024

felixguendling commented Aug 22, 2024

oleiman commented Aug 22, 2024

WillemKauf commented Aug 22, 2024

oleiman left a comment

oleiman Aug 24, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading

dotnwat commented Aug 26, 2024

oleiman commented Aug 26, 2024

oleiman commented Sep 6, 2024

Require serde_fields for all serde structs #22782

Require serde_fields for all serde structs #22782

Conversation

oleiman commented Aug 7, 2024 • edited Loading

Backports Required

Release Notes

oleiman commented Aug 7, 2024

oleiman commented Aug 7, 2024

vbotbuildovich commented Aug 8, 2024 • edited Loading

vbotbuildovich commented Aug 8, 2024 • edited Loading

oleiman commented Aug 11, 2024

oleiman commented Aug 15, 2024

oleiman commented Aug 15, 2024

oleiman commented Aug 15, 2024

dotnwat left a comment

Choose a reason for hiding this comment

oleiman commented Aug 21, 2024

WillemKauf commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 21, 2024

oleiman commented Aug 22, 2024 • edited Loading

oleiman commented Aug 22, 2024

dotnwat Aug 22, 2024

Choose a reason for hiding this comment

oleiman Aug 22, 2024

Choose a reason for hiding this comment

dotnwat commented Aug 22, 2024

felixguendling commented Aug 22, 2024

oleiman commented Aug 22, 2024

WillemKauf commented Aug 22, 2024

oleiman left a comment

Choose a reason for hiding this comment

oleiman Aug 24, 2024 • edited Loading

Choose a reason for hiding this comment

oleiman Aug 24, 2024 • edited Loading

Choose a reason for hiding this comment

oleiman Aug 24, 2024 • edited Loading

Choose a reason for hiding this comment

oleiman Aug 24, 2024 • edited Loading

Choose a reason for hiding this comment

dotnwat commented Aug 26, 2024

oleiman commented Aug 26, 2024

oleiman commented Sep 6, 2024

oleiman commented Aug 7, 2024 •

edited

Loading

vbotbuildovich commented Aug 8, 2024 •

edited

Loading

vbotbuildovich commented Aug 8, 2024 •

edited

Loading

oleiman commented Aug 22, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading

oleiman Aug 24, 2024 •

edited

Loading