c/topic_config: Explicitly initialize non-class fields #23149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we need a default constructor to keep serde happy.
7 tasks
bashtanov
approved these changes
Aug 30, 2024
|
i think we should still backport it |
Happy to do so. I didn't realize this code was on older branches. |
|
/backport v24.2.x |
dotnwat
reviewed
Aug 31, 2024
Comment on lines
-69
to
+73
| int32_t partition_count; | ||
| int32_t partition_count{0}; | ||
| // using signed integer because Kafka protocol defines it as signed int | ||
| int16_t replication_factor; | ||
| int16_t replication_factor{0}; | ||
| // bypass migration restrictions | ||
| bool is_migrated; | ||
| bool is_migrated{false}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need a default constructor to keep serde happy.
This PR adds some default initializers to
cluster::topic_configurationto avoid UB when the default constructor is used as in this function. We could/should adjust the test code to avoid this pattern, but precluding the invalid state at the struct definition is probably sufficient here.Backports Required
Release Notes