JavaScript Transforms SDK: Export SchemaFormat #23164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
force-pushed
the
xform/sdk/ts/noticket/schema-format-export
branch
from
00b0a78 to
285d20f
Compare
Helper class for building up a JavaScript object that can then be exported as part of a module's function list. Possible overkill for this use case (enum export), but it could be useful in the future if we want to export a singleton object with, for example, native function attributes.
- use container typedef - avoid blindly throwing an unbounded int into format enum
And update example transform accordingly.
oleiman
force-pushed
the
xform/sdk/ts/noticket/schema-format-export
branch
from
285d20f to
f43da48
Compare
oleiman
changed the title
rockwotj
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
SchemaFormat"enum" (really a JS object with integer-valued fields) to the schema registry module.The enum previously appeared in our TypeScript typings but was left unimplemented by mistake. Usually, the TS compiler will emit a pure JS object corresponding to such an enum, but our setup doesn't do this because the SDK module(s) are all native code, mediated by
quickjs.This PR also includes an update to the SR example code (to use the enum rather than a bare int) and some quickjs-oriented helper structs related to constructing and exporting a singleton object into a native module.
Backports Required
Release Notes
Improvements
@redpanda-data/transform-sdk-sr.SchemaFormatfor the WASM Transforms JS module