[v24.2.x] Remove shard aggregation on consumer group metrics #23627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only aggregate on the `shard` label in the consumer group metrics. This aggregation doesn't result in a reduced number of metric series. It does, however, cause seastar to use the `metric_aggregate_by_labels` class to aggregate the metrics. This class uses a contiguous map type that isn't easily replaced and in cases where there are many consumer groups, kafka topics, and partitions there is enough unique label sets to cause an oversized allocation in the continguous map. By removing the `shard` label from aggregation though we avoid the code path where `metric_aggregate_by_labels` is used and hence avoid the oversized allocation. (cherry picked from commit ca8cd1e)
BenPope
approved these changes
Oct 9, 2024
|
@ballard26 anything blocking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23339