[v24.1.x] Keep producer inflight requests queue bounded #23746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idempotent producers are allowed to produce up to 5 at a time, the five requests outcome is cached in the producer for deduplication. Previously the `_inflight_requests` list might grow unbounded if state machine apply was lagging. This causes performance issues and unnecessary memory pressure. Since the max inflight requests count is limited by producer it is enough to keep only last 5 inflight requests in the `_inflight_requests` list. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 755a890)
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/56333#01927aa3-fcbc-48a3-acff-052bbd99d73a have failed and will be retried the below tests from https://buildkite.com/redpanda/redpanda/builds/57974#019321c7-4e8d-4957-a814-705475128b44 have failed and will be retried |
|
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56333#01927ae0-51b6-4b72-b6bf-2296ea352121: non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56333#01927ae1-317e-45e7-9bfe-c006e33f5696: |
Retry command for Build#56333please wait until all jobs are finished before running the slash command |
mmaslankaprv
force-pushed
the
backport-pr-23692-v24.1.x-481
branch
from
b7bae63 to
e8dcf98
Compare
mmaslankaprv
approved these changes
Nov 12, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/57974#0193220c-9e19-4d88-a5b1-42bf76620b37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23692