[v24.1.x] gha: fix pip install on python actions #23766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivotron
changed the title
ivotron
approved these changes
Oct 12, 2024
clee
force-pushed
the
backport-v24-1-x/fix-python-action
branch
from
4045a41 to
269927d
Compare
andrewhsu
approved these changes
Oct 14, 2024
| @@ -23,7 +23,12 @@ jobs: | |||
| - name: install dependencies | |||
| env: | |||
| SCRIPT_DIR: ${{ github.workspace }}/.github/workflows/scripts | |||
| run: pip install -r ${SCRIPT_DIR}/requirements.txt | |||
| run: | | |||
| python3 -mvenv /tmp/venv/jira | |||
There was a problem hiding this comment.
fyi instead of manually creating a venv, could also use the setup-python action which updates the PATH with isolated python interpreter and save from having to source the activate script, e.g.:
- uses: actions/setup-python@v5
with:
python-version: '3.10'There was a problem hiding this comment.
oops, this comment should have gone into the lint-python.yml workflow file because there already is a setup-python above
andrewhsu
reviewed
Oct 14, 2024
| @@ -22,7 +22,10 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install yapf | |||
| run: pip install yapf==0.40.1 | |||
| run: | | |||
| python3 -mvenv /tmp/venv/yapf | |||
There was a problem hiding this comment.
fyi instead of manually creating a venv, could also use the setup-python action which updates the PATH with isolated python interpreter and save from having to source the activate script, e.g.:
- uses: actions/setup-python@v5
with:
python-version: '3.10'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23715