Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.1.x] rpk: introduce license warnings messages #23831

Merged
merged 9 commits into from
Oct 18, 2024
Merged

[v24.1.x] rpk: introduce license warnings messages #23831

merged 9 commits into from
Oct 18, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Oct 17, 2024 •
edited
Loading

Manual backport of the license warning features, PRs #23472 and #23744

Had to be done manually as in v24.1.x We don't have the BUILD files or the migration to common-go. We also had to backport #18149 to bring the rpk.yaml version bump to this branch

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@r-vasquez
rpk: move token validation message to debug
31db005 
(cherry picked from commit c1d6a56)
@r-vasquez
rpk: replace namespace for resource groups
d25468b 
This also involves upgrading the control plane API
beta v1 to v2 and dealing with the breaking changes

(cherry picked from commit 76cf8da)
@r-vasquez
rpk: update profile namespace field
0df312a 
And bump version accordingly

(cherry picked from commit c36daed)
@r-vasquez
rpk: introduce license warnings messages
b3d69da 
This commit introduces a license warning message
whenever rpk creates an admin client and the
cluster has enterprise features with an invalid
license.

(cherry picked from commit 1f1e0cd)
(cherry picked from commit c8b4b07)
@r-vasquez
rpk: redact password when printing the profile
19c7cd3 
Fixes redpanda-data#13427

(cherry picked from commit 477ccb8)
(cherry picked from commit 12a5fe8)
@r-vasquez
rpk: rename version expected sha
b4d5669 
The initial intent was to keep older version's SHAs
but we are replacing the SHA when we change the
rpk version.

(cherry picked from commit 9b69ce7)
(cherry picked from commit b579462)
@r-vasquez
rpk: change license nag cache and message
cd6e996 
(cherry picked from commit 3c30a00)
(cherry picked from commit a10bc52)
@r-vasquez
rpk: add feature violations to license info
bb835ad 
(cherry picked from commit df9943e)
(cherry picked from commit c96c1b5)
@r-vasquez
rpk: check for empty profiles in license check.
29f2278 
This is to avoid a panic in the edge case when the
user has a nameless profile (corrupted file)

(cherry picked from commit 44dfa80)
(cherry picked from commit d99160f)
@vbotbuildovich
Copy link
Collaborator

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56777#01929cc2-24e5-43ff-8821-2db8d10b999b:

"rptest.tests.partition_force_reconfiguration_test.PartitionForceReconfigurationTest.test_basic_reconfiguration.acks=1.restart=False.controller_snapshots=False"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 18, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56777#01929cc2-24e5-43ff-8821-2db8d10b999b
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56777#01929cc1-861c-4add-8863-9027a8b182e3
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56787#01929e05-7939-45c6-8100-7125ebd3dff2
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56787#01929e05-08c9-477d-8cc4-de8aefcb43f7

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 18, 2024 •
edited
Loading

Retry command for Build#56777

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/partition_force_reconfiguration_test.py::PartitionForceReconfigurationTest.test_basic_reconfiguration@{"acks":1,"controller_snapshots":false,"restart":false}
tests/rptest/tests/rpk_cluster_test.py::RpkClusterTest.test_upload_and_query_cluster_license_rpk

@r-vasquez
Copy link
Contributor Author

/ci-repeat 1
tests/rptest/tests/partition_force_reconfiguration_test.py::PartitionForceReconfigurationTest.test_basic_reconfiguration@{"acks":1,"controller_snapshots":false,"restart":false}
tests/rptest/tests/rpk_cluster_test.py::RpkClusterTest.test_upload_and_query_cluster_license_rpk

gene-redpanda
gene-redpanda approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-vasquez r-vasquez merged commit f12bb86 into redpanda-data:v24.1.x Oct 18, 2024
25 checks passed
@r-vasquez r-vasquez deleted the backport-license-v24.1.x branch October 22, 2024 18:27
@BenPope BenPope added this to the v24.1.18 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
v24.1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@r-vasquez @vbotbuildovich @gene-redpanda @BenPope