iceberg: use uppercase strings to represent data file format #23959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iceberg is a bit inconsistent when defining this. Some libraries (pyiceber in particular) requires it to be upper case string. For Redpanda the case doesn't matter as we always lower case the value when parsing it. Signed-off-by: Michał Maślanka <michal@redpanda.com>
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/57362#0192dd49-c020-43de-b94d-07f9c32674fc have failed and will be retried |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/57362#0192dd8a-8fe6-4498-9686-68deb615e1a4 |
bharathv
approved these changes
Oct 30, 2024
| @@ -143,11 +143,11 @@ data_file_content_type content_from_int(int c) { | |||
| iobuf format_to_str(data_file_format f) { | |||
| switch (f) { | |||
| case data_file_format::avro: | |||
| return iobuf::from("avro"); | |||
| return iobuf::from("AVRO"); | |||
There was a problem hiding this comment.
nit: a note here might help for future, but ok to skip to avoid another round of CI.
andrwng
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg is a bit inconsistent when defining this. Some libraries (pyiceber in particular) requires it to be upper case string. For Redpanda the case doesn't matter as we always lower case the value when parsing it.
Backports Required
Release Notes