Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] [DEVEX-36] rpk: change expiry check for free_trial #23965

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Oct 30, 2024

Manual Backport of #23951

The difference is the BUILD files and lack of common-go in v24.1.x

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

If it's a free trial license the expiry warning
check threshold will be set to 15days instead of
30 for the rest of license types.

Fixes DEVEX-36

(cherry picked from commit 76dec5a)
Now the license nags will be shown for customers
with free_trial licenses that has less than 15
days left.

(cherry picked from commit 84a3ff0)
Better readability since it's a long line.

(cherry picked from commit 663291e)
@vbotbuildovich
Copy link
Collaborator

the below tests from https://buildkite.com/redpanda/redpanda/builds/57383#0192deb6-240d-4c9c-b824-a715842634aa have failed and will be retried

cluster_health_monitor_test_rpfixture

Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-vasquez r-vasquez merged commit 48822d6 into redpanda-data:v24.1.x Oct 31, 2024
23 checks passed
@BenPope BenPope added this to the v24.1.18 milestone Nov 18, 2024
@r-vasquez r-vasquez deleted the backport-pr-23951-v24.1.x branch December 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants