[v24.1.x] rptest: reduce cache eviction throttling for space leak test #24070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is too slow with default configuration making the test flaky. Instead of raising the timeouts I'm trying to reduce the cache eviction throttling which makes the test 3x faster. The test became flaky after in-memory trim was introduced in redpanda-data#21556. The main insight was provided by https://github.com/abhijat in a private exchange: > I think it might be the extra throttling. With the carry over > disabled, we always have to do a trim when reserving space, which > results in a lot more throttling and sleep: > > ``` > $ grep -Ri "Cache trimming throttled" * | grep -c cache > 139 > ``` > > With the carryover list in place, about half of the calls to reserve > space end up in an early return because the list provides enough room > to clear up space, which does not cause the trimming to be throttled > as much: > > ``` > $ grep -Ri "Cache trimming throttled" * | grep -c cache > 63 > ``` > > Although that doesn't explain how this test used to work before, IIRC > carryover is a fairly new feature Fixes redpanda-data#21597 (cherry picked from commit 7763669)
nvartolomei
approved these changes
Nov 8, 2024
|
Backporting because this fails often in my attempts to backport other PRs which is time consuming. |
|
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/57827#01930b1e-2871-4307-b535-0c0a408f387b: |
Retry command for Build#57827please wait until all jobs are finished before running the slash command |
|
Force merge by Nicolae request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22796
Fixes: #24069,