[v24.1.x] archival: bump offset if seeking undershoots (manual backport)
#24105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert_begin_offset_to_file_pos can undershoot, in which case the metadata returned by the archival policy won't perfectly align with the caller's expectations. This could result in an offset_overlap when applying the upload metadata. It's unclear exactly why there are missing batches, given this code is used for the non-compacted uploader. But the fix is simple enough, and is one that we use in the compacted upload policy already[1]. [1] https://github.com/redpanda-data/redpanda/blob/4b8135ea5dbdca322ccf8efc85424413a20c5ade/src/v/archival/segment_reupload.cc#L516-L522 (cherry picked from commit 8b616df)
The headers are often a go-to place for information about the behavior callers should expect from a method. Adds some details explaining at a high level what to expect from a couple of methods. (cherry picked from commit ff120d0)
(cherry picked from commit 5e99303)
(cherry picked from commit 5f18ba9)
Lazin
approved these changes
Nov 13, 2024
Lazin
reviewed
Nov 13, 2024
Lazin
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #23937.
Cherry-pick conflicts due to modified bazel
BUILDfile that doesn't exist inv24.1.x.Backports Required
Release Notes
Bug Fixes
ntp_archiver_service, due to assigned start offsets being lower than they should be.