datalake/avro: fixed encoding decimal values #24113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58010#019325aa-ecf6-4abd-8485-be0d3411e004 |
rockwotj
previously approved these changes
Nov 13, 2024
mmaslankaprv
force-pushed
the
avro-decimal
branch
from
4ea056c to
798f353
Compare
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/58045#0193294e-c2d6-4e62-932c-6a62350ab24b have failed and will be retried |
mmaslankaprv
force-pushed
the
avro-decimal
branch
from
798f353 to
3fe3008
Compare
rockwotj
reviewed
Nov 14, 2024
In Java `BigInteger.toByteArray()` method is used to encode Avro decimals the method returns an array where the first element is the most significant byte of the encoded decimal. This commit fixes Redpanda Avro Bigdecimal encoding. Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
avro-decimal
branch
from
3fe3008 to
d7f13ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java
BigInteger.toByteArray()method is used to encode Avro decimals the method returns an array where the first element is the most significant byte of the encoded decimal. This commit fixes Redpanda Avro Bigdecimal encoding.Backports Required
Release Notes