[v24.1.x] audit: clamp audit client max parallelism #24149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the audit client where if the cluster config value `kafka_batch_max_bytes` is greater than `audit_client_max_buffer_size`, the audit client ends up not producing any messages and fills up the audit log buffers. The problem is the division here could lead to `max_concurrency=0`. In debug mode this is caught by an assert inside `ss::max_concurrent_for_each` but in release mode stdlibrary `assert`s are disabled and the behaviour ends up being that the background fibre just blocks waiting for a semaphore unit to be available, but it never will become available because it was initialized to 0 and no tasks will ever release any units to it. (cherry picked from commit add24d9)
pgellert
requested review from
michael-redpanda and
oleiman
and removed request for
michael-redpanda
oleiman
approved these changes
Nov 15, 2024
Apart from that I also changed |
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/58131#01933120-7e74-4079-afc7-e9e4a98168a7 have failed and will be retried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24137
Fixes #24143
Fixes: CORE-8259
Conflict was in tests only