Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazelize some enterprise tests #24153

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Bazelize some enterprise tests #24153

merged 7 commits into from
Nov 19, 2024

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Nov 18, 2024 •
edited
Loading

CORE-7596
CORE-7492
CORE-7519
CORE-7510
CORE-7505

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@oleiman
k/client: test fixture public visibility (bazel)
f820b60 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman oleiman self-assigned this Nov 18, 2024
@oleiman
Copy link
Member Author

oleiman commented Nov 18, 2024

Note to passerby: I'm going to keep pushing tests to this PR until someone gets around to signing off or I run out.

@oleiman oleiman force-pushed the bazel/enterprise-tests branch 5 times, most recently from ef3369f to fbd68bb Compare November 18, 2024 07:43
@oleiman oleiman marked this pull request as ready for review November 18, 2024 07:44
@vbotbuildovich
Copy link
Collaborator

the below tests from https://buildkite.com/redpanda/redpanda/builds/58180#01933e3e-0356-41e8-9268-20785685edcd have failed and will be retried

gtest_raft_rpunit
partition_balancer_simulator_test_rpunit

@oleiman oleiman force-pushed the bazel/enterprise-tests branch 2 times, most recently from 1fee2da to 83d8fa3 Compare November 18, 2024 17:05
dotnwat
dotnwat previously approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. did the tests pass? these are the ones i skipped because they were crashing, but i think in retrospect it was probably because i didn't add cpu=1.

@oleiman
Copy link
Member Author

oleiman commented Nov 18, 2024

lgtm. did the tests pass? these are the ones i skipped because they were crashing, but i think in retrospect it was probably because i didn't add cpu=1.

Yeah, they all pass. Some were cpu=1, and a couple of gtest fixture rules were wrongly linking boost stuff, producing "boost" tests, and failing on CLI argument errors. All fixed.

Looks like I need to tweak the test_utils factoring though as it seems to have broken some dependent rules. WIP

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58201#01934083-f9c3-42a0-81c4-db6196ccd317

dotnwat
dotnwat reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this commit

commit 505e869594eba3934a80752f2d1f8550a25c9988 (HEAD)
Author: Oren Leiman <oren.leiman@redpanda.com>
Date:   Sun Nov 17 22:51:45 2024 -0800

    kafka: Bazelize group_tx_compaction_test

seems to not be bisectable. for example:

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/v/kafka/server/tests/fetch_session_test.cc:17:10: error: module //src/v/kafka/server/tests:fetch_session_test does not depend on a module exporting 'test_utils/fixture.h'
   17 | #include "test_utils/fixture.h"
      |          ^

@oleiman
Copy link
Member Author

oleiman commented Nov 18, 2024

this commit

commit 505e869594eba3934a80752f2d1f8550a25c9988 (HEAD)
Author: Oren Leiman <oren.leiman@redpanda.com>
Date:   Sun Nov 17 22:51:45 2024 -0800

    kafka: Bazelize group_tx_compaction_test

seems to not be bisectable. for example:

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/v/kafka/server/tests/fetch_session_test.cc:17:10: error: module //src/v/kafka/server/tests:fetch_session_test does not depend on a module exporting 'test_utils/fixture.h'
   17 | #include "test_utils/fixture.h"
      |          ^

Yeah, I think 80fa8c8 needs some work. Seems like I'm pretty close locally.

@oleiman oleiman force-pushed the bazel/enterprise-tests branch from 83d8fa3 to 2f7ce6e Compare November 18, 2024 23:20
@oleiman
Copy link
Member Author

oleiman commented Nov 19, 2024 •
edited
Loading

bazel-build failure on group_tx_compaction_test timeout.

EDIT: forgot this one was added in this PR. likely timeout config issue

@oleiman oleiman force-pushed the bazel/enterprise-tests branch from 2f7ce6e to 7047b18 Compare November 19, 2024 01:30
@oleiman
audit: bazelize audit_log_test.cc
7df1de6 
CORE-7596

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman
kafka: bazelize alter_config_test
9010fe2 
And fix some includes

CORE-7492

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman
kafka: bazelize produce_consume_test
6f30a8c 
And fix up some includes

CORE-7519

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman
bazel: Refactor test fixture rules to support gtest
26e0c75 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman
kafka: Bazelize group_tx_compaction_test
ad06c7a 
CORE-7510

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman
kafka: bazelize fetch_test
c3bdc5b 
CORE-7505

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman oleiman force-pushed the bazel/enterprise-tests branch from 7047b18 to c3bdc5b Compare November 19, 2024 03:56
@oleiman
Copy link
Member Author

oleiman commented Nov 19, 2024

force push - add [[maybe_unused]] to defeat spurious unused param warning

@oleiman oleiman enabled auto-merge November 19, 2024 05:58
@oleiman oleiman disabled auto-merge November 19, 2024 06:06
rockwotj
rockwotj approved these changes Nov 19, 2024
View reviewed changes
src/v/security/audit/tests/audit_log_test.cc
@@ -95,8 +95,8 @@ FIXTURE_TEST(test_audit_init_phase, kafka_client_fixture) {
/// with auditing disabled, calls to enqueue should be no-ops
const auto n_events = pending_audit_events(audit_mgr.local()).get();
audit_mgr
.invoke_on_all([](sa::audit_log_manager& m) {
for (auto i = 0; i < 20; ++i) {
.invoke_on_all([]([[maybe_unused]] sa::audit_log_manager& m) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive compiler warning... only in cI.

@oleiman oleiman merged commit ada3f7a into redpanda-data:dev Nov 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwotj rockwotj rockwotj approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

@IoannisRP IoannisRP Awaiting requested review from IoannisRP

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees

@oleiman oleiman

Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleiman @vbotbuildovich @dotnwat @rockwotj