[v24.2.x] kafka/txn_reader: proper cleanup in finally #24096 #24300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
approved these changes
Nov 26, 2024
call finally on the underlyig reader for a proper cleanup, else bad things can happen on log reader's closure. (cherry picked from commit 349bda8)
bharathv
force-pushed
the
v242x_kafka_reader_fix
branch
from
3570ec0 to
c9e35e3
Compare
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/58755#0193669e-8c0d-489e-91ae-76b4eba81fb2 have failed and will be retried |
|
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/58755#019366dd-b04b-4f73-aa4b-182f951969bb: |
Retry command for Build#58755please wait until all jobs are finished before running the slash command |
|
Failure seems unrelated #15451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call finally on the underlying reader for a proper cleanup, else bad things can happen on log reader's closure.
Fixes #24096
(cherry picked from commit 349bda8)
Backports Required
Release Notes