archival: consistent log size probes across replicas (pull) #24342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We called update probe only from leaders and after exiting the upload loop which led to inconsistent and stale metrics. Fix this by introducing a subscription mechanism to the STM which is the source of truth for the manifest state and must be consistent across all replicas. The first attempt was in redpanda-data#24257 but the feedback suggested that the approach in this commit is better.
7 tasks
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58887#01936eb1-72e3-4d67-a8ad-ae9f474b632b |
nvartolomei
changed the title
Lazin
approved these changes
Nov 28, 2024
|
/backport v24.3.x |
|
/backport v24.2.x |
|
Failed to create a backport PR to v24.2.x branch. I tried: |
This was referenced Nov 28, 2024
|
/cdt |
|
/cdt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We called update probe only from leaders and after exiting the upload loop which led to inconsistent and stale metrics.
Fix this by introducing a subscription mechanism to the STM which is the source of truth for the manifest state and must be consistent across all replicas.
The first attempt was in
#24257 but the feedback suggested that the approach in this commit is better.
Backports Required
Release Notes
Bug Fixes
redpanda_cloud_storage_cloud_log_sizemetric consistent across all replicas. We used to update it seldomly from the leader replica only which lead to inconsistent/stale values.