rpk: fix --help in byoc and user update
#24369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mechanism flag is required in `user update` and it was not clear. It also adds an autocompletion function for those who use rpk's autocompletion features.
It fixes a bug where --help didn't work along with --redpanda-is. Fixes DEVEX-56
r-vasquez
requested review from
twmb,
gene-redpanda and
Deflaimun
as code owners
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/58997#019374a3-7ee7-4cac-b9ca-4980df5f68d3 have failed and will be retried |
|
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/58997#019374fd-5985-4734-a67b-fd483ce6a9e8: |
Retry command for Build#58997please wait until all jobs are finished before running the slash command |
|
/ci-repeat 1 |
bojand
approved these changes
Dec 2, 2024
|
/backport v24.3.x |
|
/backport v24.2.x |
|
/backport v24.1.x |
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--helpinrpk cloud byoc <provider> apply when used along with--redpanda-id` flag.mechanisminrpk security user update. And adds autocompletion to the flag.Backports Required
Release Notes
Bug Fixes
rpkwasn't parsing--helpwhen used alongside--redpanda-idinrpk cloud <provider> byoc apply